Skip to content
This repository has been archived by the owner on Mar 31, 2023. It is now read-only.

[MAC manager] Improve API consistency and code refactor #183

Merged
merged 69 commits into from
May 7, 2020
Merged

[MAC manager] Improve API consistency and code refactor #183

merged 69 commits into from
May 7, 2020

Conversation

kimeunju108
Copy link
Contributor

@kimeunju108 kimeunju108 commented Apr 30, 2020

The MAC address Manager creates and allocate MAC address for each port. Also, it manages MAC address pool and MAC address ranges, which are used when it creates MAC addresses.
Here is the brief description of MAC manager:

  • MAC address APIs: create, get, allocate, update, release

  • MAC range APIs: create, get, allocate, update, release

  • Schema update: mac_state, mac_range, mac_pool

  • Service codes: an inteface MacService and its implementation MacServiceImpl

  • Code structure: package path update for common lib, macmanager

  • Deployment: Update Application.properties and pom file

kimeunju108 and others added 30 commits April 6, 2020 03:14
Eunju/macmanager - Added MAC range APIs and MAC allocation activate/deactivate APIs
kimeunju108 and others added 3 commits April 29, 2020 01:14
[Microservices Node Manager - Add exception handlings
[Microservices] Node Manager Part 1 - Implemented and Tested
@xieus xieus changed the title [Micro Services] Node Manager [Micro-service] Node Manager Apr 30, 2020
@xieus
Copy link
Contributor

xieus commented Apr 30, 2020

We have merge conflicts here.

@xieus
Copy link
Contributor

xieus commented May 4, 2020

We have merge conflicts here.

Hi @kimeunju108 , didn't see update since the last check-in. Could you push your latest change here? Thanks.

Copy link
Contributor

@xieus xieus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kimeunju108 Mac Manager codes have been reviewed with a few minor comments. I believe we could merge Mac Manager part quickly.

As the node manager codes are all new, could we split this PR into two, i.e. by removing node manager from this PR, then create a new PR solely for node manager? Node Manager will need more rounds of review.

@xieus xieus added enhancement New feature or request unit test Unit test labels May 7, 2020
@xieus xieus added this to the Version 0.4.2020.04.30 milestone May 7, 2020
@kimeunju108 kimeunju108 changed the title [Micro-service] Node Manager [Micro-service] MAC Manager May 7, 2020
@xieus xieus changed the title [Micro-service] MAC Manager [MAC manager] Improve API consistency and code refactor May 7, 2020
@xieus xieus merged commit 189bb1e into futurewei-cloud:master May 7, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request unit test Unit test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Documentation] Mac manager design doc [Micro-service] Mac allocator
2 participants