This repository has been archived by the owner on Mar 31, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 34
[MAC manager] Improve API consistency and code refactor #183
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 336e499.
… into eunju/macmanager
… into eunju/macmanager
…implemention layer
… into eunju/macmanager
…ctivate/deactivate APIs
Eunju/macmanager - Added MAC range APIs and MAC allocation activate/deactivate APIs
… into eunju/macmanager
… neutron sections on the document
… comparison with neutron
…between document and implementation
[Microservices Node Manager - Add exception handlings
[Microservices] Node Manager Part 1 - Implemented and Tested
We have merge conflicts here. |
Hi @kimeunju108 , didn't see update since the last check-in. Could you push your latest change here? Thanks. |
… file, (2) removed memory repository part
[Microservices] Node manager - (1) added API that read machine config…
xieus
suggested changes
May 7, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kimeunju108 Mac Manager codes have been reviewed with a few minor comments. I believe we could merge Mac Manager part quickly.
As the node manager codes are all new, could we split this PR into two, i.e. by removing node manager from this PR, then create a new PR solely for node manager? Node Manager will need more rounds of review.
lib/src/main/java/com/futurewei/alcor/common/db/ignite/IgniteConfiguration.java
Show resolved
Hide resolved
services/mac_manager/src/main/java/com/futurewei/alcor/macmanager/controller/MacController.java
Show resolved
Hide resolved
services/mac_manager/src/main/java/com/futurewei/alcor/macmanager/entity/MacState.java
Show resolved
Hide resolved
xieus
changed the title
[Micro-service] MAC Manager
[MAC manager] Improve API consistency and code refactor
May 7, 2020
xieus
approved these changes
May 7, 2020
This was
linked to
issues
May 7, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The MAC address Manager creates and allocate MAC address for each port. Also, it manages MAC address pool and MAC address ranges, which are used when it creates MAC addresses.
Here is the brief description of MAC manager:
MAC address APIs: create, get, allocate, update, release
MAC range APIs: create, get, allocate, update, release
Schema update: mac_state, mac_range, mac_pool
Service codes: an inteface MacService and its implementation MacServiceImpl
Code structure: package path update for common lib, macmanager
Deployment: Update Application.properties and pom file