This repository has been archived by the owner on Mar 31, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 34
[MAC manager] Improve API consistency and impose retry limit #170
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
kimeunju108
commented
Apr 18, 2020
- Resolved the conflict between upstream and local repository
- Tested and verified the consistency between mac manager documents and implementation (e,g, API Input/ Output format)
This reverts commit 336e499.
… into eunju/macmanager
… into eunju/macmanager
…implemention layer
… into eunju/macmanager
…ctivate/deactivate APIs
Eunju/macmanager - Added MAC range APIs and MAC allocation activate/deactivate APIs
… into eunju/macmanager
… neutron sections on the document
… comparison with neutron
…between document and implementation
Please change the title of this PR to what it is exactly about. |
services/mac_manager/src/main/java/com/futurewei/alcor/macmanager/controller/MacController.java
Outdated
Show resolved
Hide resolved
xieus
reviewed
Apr 22, 2020
...ager/src/main/java/com/futurewei/alcor/macmanager/service/implement/MacRedisServiceImpl.java
Outdated
Show resolved
Hide resolved
...ager/src/main/java/com/futurewei/alcor/macmanager/service/implement/MacRedisServiceImpl.java
Outdated
Show resolved
Hide resolved
…o eunju/macmanager
[Microservices] MAC manager - synchronized redis transaction methods
Merge branch 'master' of https://github.com/futurewei-cloud/alcor int…
xieus
reviewed
Apr 22, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should revert the "synchronized" change and use Ignite transaction to solve the concurrency issue.
...ager/src/main/java/com/futurewei/alcor/macmanager/service/implement/MacRedisServiceImpl.java
Outdated
Show resolved
Hide resolved
...ager/src/main/java/com/futurewei/alcor/macmanager/service/implement/MacRedisServiceImpl.java
Outdated
Show resolved
Hide resolved
...ager/src/main/java/com/futurewei/alcor/macmanager/service/implement/MacRedisServiceImpl.java
Outdated
Show resolved
Hide resolved
...ager/src/main/java/com/futurewei/alcor/macmanager/service/implement/MacRedisServiceImpl.java
Outdated
Show resolved
Hide resolved
xieus
changed the title
[Microservices] MAC manager
[Microservices] MAC manager improvement - API consistency and impose retry limit
Apr 22, 2020
xieus
changed the title
[Microservices] MAC manager improvement - API consistency and impose retry limit
[MAC manager] Improve API consistency and impose retry limit
Apr 25, 2020
[Microservices] Node manager - add controller, service, dao, entity, …
xieus
reviewed
Apr 28, 2020
xieus
reviewed
Apr 29, 2020
lib/src/main/java/com/futurewei/alcor/common/db/ignite/IgniteConfiguration.java
Show resolved
Hide resolved
...s/node_manager/src/main/java/com/futurewei/alcor/nodemanager/service/datacenter/machine.json
Outdated
Show resolved
Hide resolved
[Microservices Node Manager - Add exception handlings
I close this PR temporarily to make a new PR of Node Manager. It looks like I could not make a new PR if there is an on-going PR. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.