Improved the bottom reaching detection. #1308
Open
+2
−2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometime I can't swipe to next chapter on vertical content.
I found that
top < this.container.scrollHeight
is always true on that broken situation. For example, top is 2199.99 and this.container.scrollHeight is 2200.epub.js/src/managers/default/index.js
Lines 496 to 501 in 3565e47
According to MDN, these numbers often have a floating decimal point.
In my smartphone(Pixel 6a), certainly screen width is 412.19px and screen height is 790.09px.
I changed the calculation formula introduced on MDN, it will correctly determine that you have reached the bottom of the container element.