-
Notifications
You must be signed in to change notification settings - Fork 126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Tagged VLAN, work at least with HPE Switch #708
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see mostly cosmetic issues here. By the way, I'm against introducing a new dependency on Math::BigInt
because of just this feature. Please try to do without it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm okay with last commits, but there's just a last minor change needed ;-)
Hi @PR-gh |
Function _getVlans (in Hardware.pm) doesn't bring all results |
Also fix a wrong test. This is a complement to #708
Hi @g-bougard, I try on many HPE switchs with dad2096 and no side effect, I have make a diff of inventory xml before/after, only difference it's ordered VLAN in VLANS. |
Take in charge Vlan for switch HPE (and other switchs) with SNMP :
dot1qVlanStaticName, dot1qVlanStaticRowStatus, dot1qVlanCurrentEgressPorts and dot1qVlanCurrentUntaggedPorts )
Add Information if the Vlan is Tagged or not.
fusioninventory/fusioninventory.github.io#66
fusioninventory/fusioninventory-for-glpi#2852