added grid for sampling a, alpha #91
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…enmc-plasma-source into fixing_random_variation
|
looks like tests are failing but some can be fixed with
|
|
closing in favour of #92 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This method of sampling ensures the model produces the same coordinates each time.
Previously we had a random sampling and this made the subsequent neutronics simulations differ with each creation of the plasma source being different.
sampling bug reported by user on the openmc forum https://openmc.discourse.group/t/different-distribution-of-neutron-density-in-openmc-plasma-source/4111/3