Allow multiple architecture native builds #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HawtJNI's description of platform is insufficient to distinguish between multiple architectures of the same operating system, such as Linux/amd64 and Linux/aarch64. Renaming and relocating these resources is necessary to create jars which will cover all available OS/arch combinations.
yselkowitz
added a commit
to multi-arch/jansi
that referenced
this pull request
Jun 17, 2019
HawtJNI's description of platform is insufficient to distinguish between multiple architectures of the same operating system, such as Linux/amd64 and Linux/aarch64. Renaming these resources is necessary to create jars which will cover all available OS/arch combinations. Required by: fusesource/jansi-native#18
|
@yselkowitz Hey, as you've seen, jansi is not in heavy development mode. Is it still something you need ? I can easily apply the patches, but I don't think I'll have the bandwidth to perform a release on all those new native libraries (not even sure how to compile them). Is that something you've already done in your work ? |
|
@gnodet, This is something I'd like to see fixed and need. I'm not familiar with how this library builds its release jars, one uber-jar or multiple jars for each platform-arch combination? I can help with building if necessary. |
|
@gnodet, do you have the keys needed to perform the release? I can help with some of the builds if told what is needed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
HawtJNI's description of platform is insufficient to distinguish between
multiple architectures of the same operating system, such as Linux/amd64
and Linux/aarch64. Renaming and relocating these resources is necessary
to create jars which will cover all available OS/arch combinations.