Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance debugging: Improve logging for FURIOSA_METADATA_EXPECT_MODIFIED patterns #3

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

hyeokjunejeon
Copy link

@hyeokjunejeon hyeokjunejeon commented Aug 23, 2024

This PR enhances the debugging information related to the FURIOSA_METADATA_EXPECT_MODIFIED setting. It provides clearer insights into whether a file is considered 'dirty' or 'pass' based on the configured patterns.

Key changes:

  • Add more detailed logging for files matching or not matching the FURIOSA_METADATA_EXPECT_MODIFIED patterns
  • Clarify which patterns are working as expected and which are not

Motivation:
Previously, we had to rely on guesswork to determine if the patterns were functioning correctly. This lack of clear information made it difficult to debug and verify the behavior of the FURIOSA_METADATA_EXPECT_MODIFIED setting.

With these changes, we can:

  1. Easily identify which files are being flagged as 'dirty' or 'pass'
  2. Quickly verify if the configured patterns are working as intended
  3. Reduce the time spent on debugging pattern-related issues

This improvement will significantly enhance our ability to manage and debug metadata-related configurations, leading to more efficient development and troubleshooting processes.

LOG

ex) export FURIOSA_METADATA_EXPECT_MODIFIED=".cargo/**:Cargo.*:crates/**/*.py:crates/**/CMakeLists.txt"
target/release/build/<package>-<hash>/stderr

FURIOSA_METADATA_EXPECT_MODIFIED=.cargo/**
FURIOSA_METADATA_EXPECT_MODIFIED=Cargo.*
FURIOSA_METADATA_EXPECT_MODIFIED=crates/**/*.py
FURIOSA_METADATA_EXPECT_MODIFIED=crates/**/CMakeLists.txt
[furiosa-metadata] Ignored an updated file ".cargo/config.toml" as it was expected.
[furiosa-metadata] Ignored an updated file "Cargo.lock" as it was expected.
[furiosa-metadata] Ignored an updated file "Cargo.toml" as it was expected.
[furiosa-metadata] Ignored an updated file "crates/xxxx/tests/python/ccc/xxxx.py" as it was expected.
[furiosa-metadata] Ignored an updated file "crates/xxxx/tests/python/ccc/xxxx2.py" as it was expected.
[furiosa-metadata] Ignored an updated file "crates/xxxxx/tests/python/furiosa_test_common/patch_torch.py" as it was expected.
[furiosa-metadata] Ignored an updated file "crates/npu-virtual-platform/CMakeLists.txt" as it was expected.
[furiosa-metadata] "crates/XXXXXXXX/include/interface/XXXXXX.hpp" is dirty.

@hyeokjunejeon hyeokjunejeon marked this pull request as ready for review August 23, 2024 04:22
@hyeokjunejeon hyeokjunejeon requested review from hyunsik and senokay and removed request for dkim-furiosa August 23, 2024 04:46
@hyeokjunejeon hyeokjunejeon self-assigned this Aug 23, 2024
@hyeokjunejeon hyeokjunejeon removed the request for review from hyunsik August 28, 2024 23:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant