Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix RNGD-related consts #109

Merged
merged 2 commits into from
Apr 23, 2024
Merged

Conversation

n0gu-furiosa
Copy link
Contributor

Fixed all RNGD-related consts according to the driver update.

@@ -20,14 +20,14 @@ use crate::DeviceResult;
pub enum Arch {
#[enumeration(alias = "Warboy")]
WarboyB0,
Renegade,
RNGD,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems Rngd is correct?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe RNGD is better. RNGD itself will become a trademark.

Copy link
Collaborator

@libc-furiosa libc-furiosa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@libc-furiosa libc-furiosa merged commit bc3cabc into furiosa-ai:main Apr 23, 2024
1 check passed
@n0gu-furiosa n0gu-furiosa deleted the fix-rngd-path branch April 23, 2024 09:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants