Introduction of a way to provide a configuration file and folder from the CLI. #380
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
funilrys
force-pushed
the
issue-377
branch
2 times, most recently
from
14e370f to
6ad83f3
Compare
This patch fixes #377. Contributors: * @spirillen
spirillen
reviewed
Sep 23, 2024
| @@ -1197,6 +1197,18 @@ def get_default_group_data() -> List[Tuple[List[str], dict]]: | |||
| "version": "%(prog)s " + PyFunceble.storage.PROJECT_VERSION, | |||
| }, | |||
| ), | |||
| ( | |||
| [ | |||
| "--config-file", | |||
There was a problem hiding this comment.
--config-file => --config-dir
the equivalent to ~/.config/PyFunceble with all the config files, since the values of ~/.config/PyFunceble/.pyfunceble-env are not picked up in when running in venv
|
As mentioned in the comment, https://github.com/funilrys/PyFunceble/pull/380/files#r1771238700, then none of the config/setup files from the default root config dir are picked up when running in python venv as it is a virtual closed environment. This means it is the dir_path to the config files "collection" not only /home/$USER/.config/PyFunceble
├── /home/$USER/.config/PyFunceble/dir_structure.json
├── /home/$USER/.config/PyFunceble/iana-domains-db.json
├── /home/$USER/.config/PyFunceble/.idea
│ ├── /home/$USER/.config/PyFunceble/.idea/.gitignore
│ ├── /home/$USER/.config/PyFunceble/.idea/misc.xml
│ ├── /home/$USER/.config/PyFunceble/.idea/modules.xml
│ ├── /home/$USER/.config/PyFunceble/.idea/PyFunceble.iml
│ └── /home/$USER/.config/PyFunceble/.idea/workspace.xml
├── /home/$USER/.config/PyFunceble/inactive.csv
├── /home/$USER/.config/PyFunceble/ipv4_reputation.data
├── /home/$USER/.config/PyFunceble/public-suffix.json
├── /home/$USER/.config/PyFunceble/.pyfunceble-env
├── /home/$USER/.config/PyFunceble/.pyfunceble_intern_downtime.json
├── /home/$USER/.config/PyFunceble/.PyFunceble.overwrite.yaml
├── /home/$USER/.config/PyFunceble/.PyFunceble.yaml
├── /home/$USER/.config/PyFunceble/user_agents.json
└── /home/$USER/.config/PyFunceble/whois.csv |
This patch fixes #377. Contributors: * @spirillen
|
@spirillen added a |
Indeed, before this patch, any custom configuration may have been destroyed when config_file and config_dir has been changed.
I will, is it released on pipy or repo only? |
funilrys
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch fixes #377.
Contributors:
Hey @spirillen & others. I'm lookinf for tester before getting this merged. Could you please test this branch and let me know ?
Thanks!