CI for linting swc minification problem

.github/workflows/ci.yml

@@ -17,7 +17,15 @@ jobs:
     strategy:
       fail-fast: false
       matrix:
-        node: [14.21.3, 16.20.0, 18.19.0, 20.10.0]
+        TEST262_NODE_VERSION: [14.21.3, 16.20.0, 18.19.0, 20.10.0]
+        include:
+          - TEST262_NODE_VERSION: 14.21.3
+            TEST262_ESM: 1
+            LINTING: 1
+          - TEST262_NODE_VERSION: 16.20.0
+            TEST262_ESM: terser
+          - TEST262_NODE_VERSION: 18.19.0
+            TEST262_ESM: swc
 
     steps:
       - name: Checkout
@@ -41,12 +49,14 @@ jobs:
         run: pnpm install
 
       - name: Lint
-        # Only for the first Node version
-        if: matrix.node == '14.21.3'
+        if: matrix.LINTING
         run: pnpm run lint
 
       - name: Build
         run: pnpm run build
 
       - name: Test
-        run: TEST262_NODE_VERSION=${{ matrix.node }} pnpm run test
+        run: >
+          TEST262_NODE_VERSION=${{ matrix.TEST262_NODE_VERSION }}
+          TEST262_ESM=${{ matrix.TEST262_ESM }}
+          pnpm run test

packages/temporal-polyfill/package.json

@@ -93,13 +93,15 @@
   "devDependencies": {
     "@biomejs/biome": "1.5.1",
     "@js-temporal/temporal-test262-runner": "workspace:*",
+    "@swc/core": "1.4.11",
     "@types/node": "^18.11.9",
     "concurrently": "^8.2.0",
     "export-size": "workspace:*",
     "gzip-size-cli": "^5.1.0",
     "rollup": "^4.9.6",
     "rollup-plugin-dts": "^6.1.0",
     "rollup-plugin-sourcemaps": "^0.6.3",
+    "rollup-plugin-swc3": "^0.11.0",
     "terser": "^5.27.0",
     "typescript": "~5.3.3",
     "vitest": "^1.2.2",
@@ -109,6 +111,10 @@
     "@biomejs/biome": [
       "BUG: Pinned to 1.5.1 due to this regression in 1.5.3:",
       "https://github.com/biomejs/biome/issues/1654"
+    ],
+    "@swc/core": [
+      "Locked a version to test workaround for this bug:",
+      "https://github.com/swc-project/swc/issues/8806"
     ]
   }
 }

packages/temporal-polyfill/scripts/bundle.js

@@ -10,6 +10,7 @@ import { readFile } from 'fs/promises'
 import { rollup as rollupBuild, watch as rollupWatch } from 'rollup'
 import { dts } from 'rollup-plugin-dts'
 import sourcemaps from 'rollup-plugin-sourcemaps'
+import { minify as swcMinify } from 'rollup-plugin-swc3'
 import { extensions } from './lib/config.js'
 import { pureTopLevel } from './lib/pure-top-level.js'
 import { terserSimple } from './lib/terser-simple.js'
@@ -18,33 +19,39 @@ const argv = process.argv.slice(2)
 writeBundles(
   joinPaths(process.argv[1], '../..'),
   argv.includes('--dev'),
-  argv.includes('--esm') || process.env.CI,
+  argv.includes('--esm') || process.env.TEST262_ESM === '1',
+  argv.includes('--esm-terser') || process.env.TEST262_ESM === 'terser',
+  argv.includes('--esm-swc') || process.env.TEST262_ESM === 'swc',
 )
 
-async function writeBundles(pkgDir, isDev, bundleDistEsm) {
+async function writeBundles(
+  pkgDir,
+  isDev,
+  bundleEsm,
+  bundleEsmTerser,
+  bundleEsmSwc,
+) {
   const configs = await buildConfigs(pkgDir, isDev)
   await (isDev ? watchWithConfigs : buildWithConfigs)(configs)
 
-  if (bundleDistEsm) {
+  if (bundleEsm || bundleEsmTerser || bundleEsmSwc) {
     const esmBundle = await rollupBuild({
       input: joinPaths(pkgDir, 'dist', 'global' + extensions.esm),
     })
-    await Promise.all([
-      esmBundle.write({
-        format: 'iife',
-        file: joinPaths(pkgDir, 'dist', '.bundled', 'global' + extensions.iife),
-      }),
-      esmBundle.write({
-        format: 'iife',
-        file: joinPaths(
-          pkgDir,
-          'dist',
-          '.bundled',
-          'global' + extensions.iifeMin,
-        ),
-        plugins: [terserSimple()],
-      }),
-    ])
+
+    const filename =
+      'global' +
+      (bundleEsmTerser
+        ? '.terser' + extensions.iifeMin
+        : bundleEsmSwc
+          ? '.swc' + extensions.iifeMin
+          : extensions.iife)
+
+    await esmBundle.write({
+      format: 'iife',
+      file: joinPaths(pkgDir, 'dist', '.bundled', filename),
+      plugins: [bundleEsmTerser && terserSimple(), bundleEsmSwc && swcMinify()],
+    })
   }
 }
 

packages/temporal-polyfill/scripts/test262.js

@@ -101,9 +101,15 @@ yargs(hideBin(process.argv))
         min = min || Boolean(Math.floor(currentNodeMajorVersion / 2) % 2)
       }
 
-      const polyfillPath = // from package root
-        (esm ? './dist/.bundled/global' : './dist/global') +
-        (min ? extensions.iifeMin : extensions.iife)
+      const esmOpt = process.env.TEST262_ESM
+
+      // from package root
+      const polyfillPath = esmOpt
+        ? './dist/.bundled/global' +
+          (esmOpt === 'terser' || esmOpt === 'swc'
+            ? '.' + esmOpt + extensions.iifeMin
+            : extensions.iife)
+        : './dist/global' + extensions.iife
 
       console.log(`Testing ${polyfillPath} with Node ${currentNodeVersion} ...`)