Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

General Assignments Service Refactor #386

Merged
merged 15 commits into from
Nov 17, 2023
Merged

General Assignments Service Refactor #386

merged 15 commits into from
Nov 17, 2023

Conversation

Clashsoft
Copy link
Member

  • Changed remaining assignment and solution references to ObjectId.
  • Improved some aggregation pipelines.
  • Used MongooseRepository and EventRepository everywhere to reduce boilerplate.

@Clashsoft
refactor(assignments-service): Move helper methods to AssigneeService
edcda55
@Clashsoft
refactor(assignments-service): Use MongooseRepository for AssignmentS…
744fae0 
…ervice
@Clashsoft
fix(assignments-service): Use ObjectId for assignment IDs
703645a
@Clashsoft
refactor(assignments-service): Use MongooseRepository for CommentService
ae5aa96
@Clashsoft
refactor(assignments-service): Use MongooseRepository for SolutionSer…
11db978 
…vice
@Clashsoft
refactor(assignments-service): Use MongooseRepository for EvaluationS…
b10bcbb 
…ervice
@Clashsoft
Merge branch 'master' into refactor/assignments-service
6150c7f
@Clashsoft
fix(assignments-service): Wrong parameter names in EvaluationController
612f053
@Clashsoft
refactor(assignments-service): Change Solution.assignment to ObjectId
aa33de2
@Clashsoft
fix(assignments-service): Course students aggregation
c721576
@Clashsoft
refactor(assignments-service): Improve solutions with 3P consent quer…
1c05540 
…y in EmbeddingService
@Clashsoft
refactor(assignments-service): Improve solutions statistics query wit…
a4cbfb2 
…h aggregate
@Clashsoft
refactor(assignments-service): Change Comment.assignment and solution…
c0dba36 
… to ObjectId
@Clashsoft
fix(assignments-service): Make AssigneeService an EventRepository
65df0cf
@Clashsoft Clashsoft added the enhancement New feature or request label Nov 17, 2023
@Clashsoft Clashsoft added this to the v1.17.0 milestone Nov 17, 2023
@Clashsoft Clashsoft self-assigned this Nov 17, 2023
@Clashsoft Clashsoft merged commit de0f763 into master Nov 17, 2023
3 checks passed
@Clashsoft Clashsoft deleted the refactor/assignments-service branch November 17, 2023 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Clashsoft Clashsoft

Labels
enhancement New feature or request
Projects
None yet
Milestone
v1.17.0
Development

Successfully merging this pull request may close these issues.
1 participant
@Clashsoft