fix(assignments-service): Improper validation and transformation of a…

…rray bodies
fujaba · Nov 17, 2023 · a8ee22c · a8ee22c
1 parent e2ef1ab
commit a8ee22c
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/services/apps/assignments/src/assignee/assignee.controller.ts b/services/apps/assignments/src/assignee/assignee.controller.ts
@@ -1,5 +1,5 @@
 import {NotFound, ObjectIdPipe} from '@mean-stream/nestx';
-import {Body, Controller, Delete, Get, Param, Patch, Put} from '@nestjs/common';
+import {Body, Controller, Delete, Get, Param, ParseArrayPipe, Patch, Put} from '@nestjs/common';
 import {ApiOkResponse, ApiOperation, ApiTags} from '@nestjs/swagger';
 import {AssignmentAuth} from '../assignment/assignment-auth.decorator';
 import {BulkUpdateAssigneeDto, PatchAssigneeDto, UpdateAssigneeDto} from './assignee.dto';
@@ -42,7 +42,7 @@ export class AssigneeController {
   @ApiOkResponse({type: Assignee})
   async updateMany(
     @Param('assignment', ObjectIdPipe) assignment: Types.ObjectId,
-    @Body() dtos: BulkUpdateAssigneeDto[],
+    @Body(new ParseArrayPipe({ items: BulkUpdateAssigneeDto })) dtos: BulkUpdateAssigneeDto[],
   ): Promise<Assignee[]> {
     return this.assigneeService.upsertMany(assignment, dtos);
   }

diff --git a/services/apps/assignments/src/solution/solution.controller.ts b/services/apps/assignments/src/solution/solution.controller.ts
@@ -175,7 +175,7 @@ export class SolutionController {
   @ApiOkResponse({type: [Solution]})
   async updateMany(
     @Param('assignment', ObjectIdPipe) assignment: Types.ObjectId,
-    @Body() dtos: BatchUpdateSolutionDto[],
+    @Body(new ParseArrayPipe({items: BatchUpdateSolutionDto })) dtos: BatchUpdateSolutionDto[],
   ): Promise<(Solution | null)[]> {
     return this.solutionService.batchUpdate(assignment, dtos);
   }