Skip to content

Commit

Permalink
Merge pull request #29 from fuchicorp/bugfix/deployment_endpoint
Browse files Browse the repository at this point in the history
Deployment endpoint is optional from now
  • Loading branch information
fsadykov authored Mar 3, 2022
2 parents 2f0ab93 + 72b8f35 commit aeca5d6
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
3 changes: 1 addition & 2 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -103,7 +103,7 @@ For more info, please see the [variables file](https://github.com/fuchicorp/terr

| Variable | Description | Default | Type |
| :----------------------- | :------------------------------------------------------------------------------------------ | :----------: | :-------------: |
| `deployment_endpoint` | Ingress endpoint `example.fuchicorp.com` | `(Required)` | `domain/string` |
| `deployment_endpoint` | Ingress endpoint `example.fuchicorp.com` | `(Optional)` | `domain/string` |
| `deployment_name` | The name of the deployment for helm release | `(Required)` | `string` |
| `deployment_environment` | Name of the namespace | `(Required)` | `string` |
| `deployment_path` | path for helm chart on local | `(Required)` | `string` |
Expand All @@ -128,7 +128,6 @@ In a case of remote chart deployment, you can follow the above instruction and u
module "helm_deploy_remote" {
source = "fuchicorp/chart/helm"
version = "0.0.10"
deployment_endpoint = "grafana.fuchicorp.com"
deployment_name = "grafana"
deployment_environment = "dev"
deployment_path = "grafana/grafana"
Expand Down
3 changes: 2 additions & 1 deletion variables.tf
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
variable "deployment_endpoint" {
description = "-(Required) Endpoint for the application"
description = "-(Optional) Endpoint for the application"
default = "example.local"
}

variable "deployment_name" {
Expand Down

0 comments on commit aeca5d6

Please sign in to comment.