Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Proposition] Allow user to reset setting to default values #630

Merged
merged 3 commits into from
Dec 18, 2023

Conversation

MangelMaxime
Copy link
Contributor

When reporting issues I always have a hard top finding the correct configuration because I never know which settings changed or not.

Adding this button allows the user to restore the default settings of Fantomas to start from a blank page

@MangelMaxime MangelMaxime changed the title Allow user to reset setting to default values [Proposition] Allow user to reset setting to default values Dec 15, 2023
@dawedawe
Copy link
Member

dawedawe commented Dec 18, 2023

Love it. Thanks a lot! How about putting the button on top of the settings? That would be a nicer UX from my view.

@MangelMaxime
Copy link
Contributor Author

I agree that having it at the top of the setting would be better.

But I am struggling with finding a place that feels nice for it.

Right now the one that feels the least out of place is this one:

CleanShot 2023-12-18 at 09 47 32@2x

@dawedawe
Copy link
Member

That would be fine for me :)

Copy link
Collaborator

@nojaf nojaf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm ok with having this.
Please move it higher though.

src/client/src/styles/style.css Outdated Show resolved Hide resolved
src/client/fsharp/FantomasOnline/View.fs Show resolved Hide resolved
Copy link
Collaborator

@nojaf nojaf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great stuff, thanks @MangelMaxime!

@nojaf nojaf merged commit c9d69a9 into fsprojects:main Dec 18, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants