Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

An adaptation of FSharp.Charting to .NET Core 3.1 on Windows 10. #145

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

hello-sergei
Copy link

Needed this for rapid debugging. Thought it could be of interest to others. Don't have enough knowledge about the code base for accurately merging into master without causing regressions on other .NET variants, thus created the incubation directory.

The changes are minor, yet they were tricky to figure out, especially in the configuration files. I hope it'll save you time in case you'd like to keep the library going. Also, the FSharp.Charting example in the Expert F# 4.0 book will now work on .NET Core 3.1.

Not sure how well the configuration files will be processed by Visual Studio. A working JetBrains Rider 2019.3.1 solution can be found here: https://github.com/hello-sergei/FsharpChartingCore. Thanks for the wonderful F# ecosystem!

@ism
Copy link
Contributor

ism commented Jul 6, 2020

Thank you for that! I am having hard times to make it work in .net core 3.1 for windows 10, hope this one helps.

@dsyme
Copy link
Member

dsyme commented Jul 6, 2020

This looks very promising.

Don't have enough knowledge about the code base for accurately merging into master without causing regressions on other .NET variants, thus created the incubation directory.

If it's working well I think we should just make this the new v3.0 version going forward (so v2.0 is the last for .NET Framework)

@dsyme
Copy link
Member

dsyme commented Jul 6, 2020

@hello-sergei Could you rejig things so that this literally replaces the current version? Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants