Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply redesign #7

Merged
merged 14 commits into from
Jul 11, 2024
Merged

Apply redesign #7

merged 14 commits into from
Jul 11, 2024

Conversation

kritzl
Copy link
Contributor

@kritzl kritzl commented Jul 11, 2024

No description provided.

@kritzl kritzl marked this pull request as ready for review July 11, 2024 16:05
@kritzl kritzl requested a review from lilioid July 11, 2024 16:05
Copy link
Member

@lilioid lilioid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally really nice :D Goo job!

  1. Can you either add spacing between the buttons and/or make them more like clickable links (e.g. using an underline. just something that is recognizable by users) and/or add icons?
    image

  2. (optional) Could we make the logo prettier? Maybe usign a different font or using an ouline instead of the plain text?
    image

@lilioid
Copy link
Member

lilioid commented Jul 11, 2024

Also, running the docker container in a production-like setting gives the following error during startup:

CommandError: 
It looks like node.js and/or npm is not installed or cannot be found.

Visit https://nodejs.org to download and install node.js for your system.

If you have npm installed and still getting this error message, set NPM_BIN_PATH variable in settings.py to match path of NPM executable in your system.

Example:
NPM_BIN_PATH = "/usr/local/bin/npm"

@kritzl kritzl requested a review from lilioid July 11, 2024 16:40
@kritzl kritzl merged commit c6ff6d6 into feature/transaction_webhooks Jul 11, 2024
2 checks passed
@kritzl kritzl deleted the feature/redesign branch July 11, 2024 17:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants