Integrate particle source #84
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hopefully, the regression test is fixed. |
|
@fsciortino I need the approval of this pull request. I'm not allowed to merge it before approval. All regression tests have passed, so hopefully the installation issues are fixed. |
fsciortino
reviewed
Dec 9, 2023
aurora/adas_files.py
Outdated
| @@ -32,7 +32,7 @@ | |||
| ) | |||
|
|
|||
|
|
|||
| def get_adas_file_loc(filename, filetype="adf11"): | |||
| def get_adas_file_loc(filename, filetype="adf11", tmp_folder=None): | |||
There was a problem hiding this comment.
@odstrcilt why do you need this tmp_folder here?
There was a problem hiding this comment.
I have no idea. I will fix it.
|
@fsciortino ready to be merged |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Integrate particle source over the timestep of the simulation. It will reduce particle conservation error for noisy or fast varying impurity sources.