PR: from frugalos_dyn to master #1
Conversation
src/galois.c
Outdated
| if (!gfp) { | ||
| gf2p = (gf2_t *) malloc(sizeof(gf2_t)); | ||
| gf2p->gf = (gf_t *) malloc(sizeof(gf_t)); | ||
| if (!gf2p || gf2p->gf) { |
There was a problem hiding this comment.
Should this line be like if (!gf2p || !gf2p->gf)?
| { | ||
| int *matrix, i; | ||
|
|
||
| if (m == 2 && k <= cbest_max_k[w]) { | ||
| matrix = talloc(int, k*m); | ||
| if (matrix == NULL) return NULL; | ||
| if (!cbest_init) { | ||
| if (!cbest_init) { /* not safe for multithreads. need CAS */ |
| extern int galois_uninit_field(int w); | ||
| extern void galois_change_technique(gf_t *gf, int w); | ||
| typedef struct gf2_t_ { | ||
| gf_t* gf; |
There was a problem hiding this comment.
I don't get why this member is necessary.
I think it's okay to remove this member and make galois_init_field return both gf2_t and gf_t created.
I'm commenting because it seems that gf2_t is the global state packed in a struct, and gf_t* gf created in galois_init_field doesn't look like a global state and is not used elsewhere in this repository.
(except initialization and galois_destroy, of course!)
| gf_t* gf; | ||
| gf_t* gfp_array[64]; | ||
| int gfp_is_composite[64]; | ||
| } gf2_t; |
There was a problem hiding this comment.
I really don't recommend naming this struct as gf2_t because it is easily confused with GF(2), the finite field with two elements. (gf_state_t should be better I think?)
|
Should refer to frugalos/liberasurecode#4 |
frugalos_dynブランチは以下の内容を含む:
（libFrugalosJerasureへの変更などは、openstack/liberasurecodeの変更などを生む）