fix password crypt hash being always evaluated to argon2i as the case…

… always returns true if PASSWORD_ARGON2I is defined but the froxlor setting might be set to another hash leading to a useless password Signed-off-by: Michael Kaufmann <[email protected]>
froxlor · Feb 3, 2024 · ece4b34 · ece4b34
1 parent 9c70976
commit ece4b34
Showing 1 changed file with 4 additions and 4 deletions.
diff --git a/lib/Froxlor/Api/Commands/EmailAccounts.php b/lib/Froxlor/Api/Commands/EmailAccounts.php
@@ -157,10 +157,10 @@ public function add()
 
 			// prefix hash-algo
 			switch (Settings::Get('system.passwordcryptfunc')) {
-				case defined('PASSWORD_ARGON2I') && PASSWORD_ARGON2I:
+				case 'argon2i':
 					$cpPrefix = '{ARGON2I}';
 					break;
-				case defined('PASSWORD_ARGON2ID') && PASSWORD_ARGON2ID:
+				case 'argon2id':
 					$cpPrefix = '{ARGON2ID}';
 					break;
 				default:
@@ -404,10 +404,10 @@ public function update()
 			$password = Crypt::validatePassword($password, true);
 			// prefix hash-algo
 			switch (Settings::Get('system.passwordcryptfunc')) {
-				case defined('PASSWORD_ARGON2I') && PASSWORD_ARGON2I:
+				case 'argon2i':
 					$cpPrefix = '{ARGON2I}';
 					break;
-				case defined('PASSWORD_ARGON2ID') && PASSWORD_ARGON2ID:
+				case 'argon2id':
 					$cpPrefix = '{ARGON2ID}';
 					break;
 				default: