Fix "expires" option cannot have a year greater than 9999 (#1246)

This fixes the exception: '"expires" option cannot have a year greater than 9999', which happens on upgrade from Debian 11 to 12. The session timeout in the DB is 9999999999999, so we constrain the value.
froxlor · Mar 25, 2024 · 5909401 · 5909401
1 parent 809e8ef
commit 5909401
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 1 deletion.
diff --git a/actions/admin/settings/110.accounts.php b/actions/admin/settings/110.accounts.php
@@ -35,6 +35,7 @@
 					'varname' => 'sessiontimeout',
 					'type' => 'number',
 					'min' => 60,
+					'max' => 31536000,
 					'default' => 600,
 					'save_method' => 'storeSettingField'
 				],

diff --git a/lib/init.php b/lib/init.php
@@ -369,7 +369,7 @@
 	}
 	// update cookie lifetime
 	$cookie_params = [
-		'expires' => time() + Settings::Get('session.sessiontimeout'),
+		'expires' => time() + min(Settings::Get('session.sessiontimeout'), 31536000),
 		'path' => '/',
 		'domain' => UI::getCookieHost(),
 		'secure' => UI::requestIsHttps(),