Merge pull request #3 from xini/fix-cms-edit-links

fix cms edit links
fromholdio · Nov 4, 2021 · 229efeb · 229efeb
2 parents 4a206b2 + 8a0fd19
commit 229efeb
Show file tree

Hide file tree

Showing 2 changed files with 39 additions and 4 deletions.
diff --git a/src/Model/MenuItem.php b/src/Model/MenuItem.php
@@ -290,17 +290,23 @@ public function CMSEditLink()
     {
         $link = null;
         if ($this->ParentID) {
+            $link = $this->Parent()->CMSEditLink();
+            $link = preg_replace('/\/item\/([\d]+)\/edit/', '/item/$1', $link);
             $link = Controller::join_links(
-                $this->Parent()->CMSEditLink(),
+                $link,
                 'ItemEditForm/field/Children/item',
-                $this->ID
+                $this->ID,
+                'edit'
             );
         }
         else if ($this->MenuSetID) {
+            $link = $this->MenuSet()->CMSEditLink();
+            $link = preg_replace('/\/item\/([\d]+)\/edit/', '/item/$1', $link);
             $link = Controller::join_links(
-                $this->MenuSet()->CMSEditLink(),
+                $link,
                 'ItemEditForm/field/Items/item',
-                $this->ID
+                $this->ID,
+                'edit'
             );
         }
         $this->extend('updateCMSEditLink', $link);

diff --git a/src/Model/MenuSet.php b/src/Model/MenuSet.php
@@ -4,6 +4,8 @@
 
 use Fromholdio\GridFieldLimiter\Forms\GridFieldLimiter;
 use SilverStripe\Admin\LeftAndMain;
+use SilverStripe\CMS\Controllers\CMSPageEditController;
+use SilverStripe\CMS\Model\SiteTree;
 use SilverStripe\Control\Controller;
 use SilverStripe\Core\ClassInfo;
 use SilverStripe\Core\Config\Config;
@@ -22,6 +24,8 @@
 use SilverStripe\Forms\GridField\GridFieldToolbarHeader;
 use SilverStripe\ORM\ArrayList;
 use SilverStripe\ORM\DataObject;
+use SilverStripe\SiteConfig\SiteConfig;
+use SilverStripe\SiteConfig\SiteConfigLeftAndMain;
 use SilverStripe\Security\Permission;
 use SilverStripe\Security\PermissionProvider;
 use SilverStripe\Versioned\Versioned;
@@ -448,6 +452,31 @@ public function getCMSFields()
         return $fields;
     }
 
+    public function CMSEditLink()
+    {
+        $link = null;
+        if ($this->ParentID) {
+            if (is_a($this->Parent(), SiteTree::class)) {
+                $link = Controller::join_links(
+                    singleton(CMSPageEditController::class)->Link('EditForm'),
+                    $this->ParentID,
+                    'field/MenuSets/item',
+                    $this->ID,
+                    'edit'
+                );
+            } elseif (is_a($this->Parent(), SiteConfig::class)) {
+                $link = Controller::join_links(
+                    singleton(SiteConfigLeftAndMain::class)->Link('EditForm'),
+                    'field/MenuSets/item',
+                    $this->ID,
+                    'edit'
+                );
+            }
+        }
+        $this->extend('updateCMSEditLink', $link);
+        return $link;
+    }
+
     public function canCreate($member = null, $context = null)
     {
         return Permission::checkMember($member, 'CREATE_MENUSETS');