Avoid Deno namespace
#39
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wojpawlik
force-pushed
the
avoid-deno.ns
branch
from
e52e9c1
to
d5ad0db
Compare
KnorpelSenf
approved these changes
Aug 18, 2023
|
Consistency is just nice to have |
|
I don't really know what will be more consistent here, it looks to me like you're just increasing how much favour Node APIs over Deno APIs |
wojpawlik
force-pushed
the
avoid-deno.ns
branch
from
3bdf368
to
f330ef1
Compare
wojpawlik
force-pushed
the
avoid-deno.ns
branch
from
f330ef1
to
938422f
Compare
|
I'm happy to keep shrinking the Deno namespace shim; it's obsoleted by |
|
I'm too tired of your continuous force-pushing to review this, I'll unsubscribe, sorry |
wojpawlik
added a commit
that referenced
this pull request
Oct 6, 2023
Also switches `cli.ts` from `Deno` to `process` (#39)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.