Make attachment model classes dynamic

[wimski]

In my current project I work with UUID's for all my models. I want the Froala attachments to also use UUID's instead of integers. To do this I need to extend the models and set their $keyType property to string. This currently isn't possible so I've made the model classes dynamic so you can easily swap them with extensions.

<?php

namespace App\Models\Froala;

use Froala\NovaFroalaField\Models\Attachment as OriginalAttachment;

class Attachment extends OriginalAttachment
{
    protected $keyType = 'string';
}

// froala-field.php config
'attachment_model'  => App\Models\Froala\Attachment::class,

[slavarazum]

Let's get model class from config directly, without requirement to pass it into constructor.
Also let's omit "name" suffix and attachment prefix, we already in DetachAttachment class context. The repetition of context is mostly redundant.

[wimski]

Let's get model class from config directly, without requirement to pass it into constructor.

Why would you create a tight coupling between the handlers, which are small and single-purpose classes, and the config helper? There's no need for them to know about the framework and its helpers. Injecting the model class makes them less dependent.

Also let's omit "name" suffix and attachment prefix, we already in DetachAttachment class context. The repetition of context is mostly redundant.

Why not be as explicit as possible? Is there a cost to having a slightly longer variable/property name?

[slavarazum]

Extract get table of class string to the own method.

[wimski]

That doesn't sound very DRY. Any specific reason for introducing code duplication?