-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature angular ui #12
base: master
Are you sure you want to change the base?
Conversation
I removed assert.js altogether. We'll be using nodejs/assert instead. |
Every file is going to have strict mode on. |
Server files moved to ./server
}); | ||
|
||
corpus.factory('CorpusDB', function () { | ||
var codes = [ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The corpus should be loaded from the text file corpus.dump
instead of embedded in-line. The corpus.dump
file should be git-controlled source code (not json). We can eventually factor this out as a pomagma-corpus repo, but I am in no hurry.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(FYI The corpus file format has been stable for over a year, since before the original python-sqlite-git bridge https://github.com/fritzo/pomagma/blob/5aa8ee82ef6b0133cd5ed026d0db3b41167c2e02/src/corpus.py )
APP fires up and upon an incoming findAll event updates the HTML view.
We might later have backup.corpus etc.corpus ... File is not being used now.
DO NOT MERGE - for discussion only