Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature angular ui #12

Open
wants to merge 20 commits into
base: master
Choose a base branch
from
Open

Feature angular ui #12

wants to merge 20 commits into from

Conversation

fritzo
Copy link
Owner

@fritzo fritzo commented Aug 28, 2014

DO NOT MERGE - for discussion only

@yangit
Copy link
Contributor

yangit commented Aug 29, 2014

I removed assert.js altogether. We'll be using nodejs/assert instead.
DOC is now in a broken state as I basically threw away most of the code and will be refactoring it back into angular controllers.
There is clientSrc-old/ folder and it will be there until I finish refactoring.
I do not want to merge into master now as angular-ui branch is in uncompleted state. It is basically only a scaffolding without any functionality. As I move most of editor functionality to this branch I will merge it to master.

@yangit
Copy link
Contributor

yangit commented Aug 29, 2014

Every file is going to have strict mode on.
jshint will not pass otherwise.

});

corpus.factory('CorpusDB', function () {
var codes = [
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The corpus should be loaded from the text file corpus.dump instead of embedded in-line. The corpus.dump file should be git-controlled source code (not json). We can eventually factor this out as a pomagma-corpus repo, but I am in no hurry.

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(FYI The corpus file format has been stable for over a year, since before the original python-sqlite-git bridge https://github.com/fritzo/pomagma/blob/5aa8ee82ef6b0133cd5ed026d0db3b41167c2e02/src/corpus.py )

APP fires up and upon an incoming findAll event updates the HTML view.
We might later have backup.corpus etc.corpus ...
File is not being used now.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants