Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix simulator bugs and a few improvements #3966

Open
wants to merge 16 commits into
base: main
Choose a base branch
from

Conversation

failiz
Copy link
Contributor

@failiz failiz commented Aug 1, 2022

Adds RGB leds and photocells to the simulator
Shows resistance property after family
Scales and centers smokes comming out of parts
Add reason to not simulate a part

failiz added 15 commits July 20, 2022 14:52
…t of the multimeters changes to white and it is impossible to see.
…smoke at the center of the part) and scale it for big parts
…g for that ModuleID. The message that shows this errors also specifies the name of the FPZ file.
…out if instanceTitle is the same as the one being simulated (it looks like there are two ItemBase created for each part).
@KjellMorgenstern
Copy link
Member

KjellMorgenstern commented Mar 9, 2023

Last week we have been debugging a problem. Fritzing sometimes crashes when m_simItems get deleted.
This is already in 0.9.10, and happens not very often:

Date:   Sun Dec 6 23:16:30 2020 +0100
    fixed problem with dangling pointers. Now, the simulation items are stored in ItemBase.

However, with the new "Not connected / no SPICE data" information display, this gets triggered much more often. We tried QTs deleteLater and other mechanisms, but the only way to avoid the crash seems to leak the memory. I have to look into this again at some point, I think there must be something wrong about how these are handled, not only with the way they are deleted. My next approach would be to make them a fixed element of the item, and only change the appearance (visibility, smoke, text label... )

@failiz
Copy link
Contributor Author

failiz commented Mar 9, 2023

I do not like this kind of problem and I am not sure what the reason is. I hope you can fix it.
The good thing is that it is easier to trigger now. Thus, it is easier to check if the solution works...
By the way, I started to work on transitory analysis. It does not seem difficult. I am not sure if I will have to run the simulator twice (one for the DC operating point for multimeters and others and another time for the oscilloscope). I think that ngspice makes an operating point to start the transitory simulation, but not sure if I can get the data easily. In any case, I am quite busy at the moment and it will probably not make it for the next release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants