forked from MaurycyLiebner/enve
-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Preview rearranged #370
Draft
pgilfernandez
wants to merge
5
commits into
friction2d:main
Choose a base branch
from
pgilfernandez:preview_rearranged
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Preview rearranged #370
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To be honest I don't understand the change, please explain. To me this looks like a downgrade. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a suggestion to change the arrangement of icon in the Preview toolbar. I feel like the UX could be improved here.
I started by checking how other common FOSS do (not including some if their UX was not inline with our set of icons, for instance Kdenlive):
Then I created a new set of icons and started playing with rearrangement and therefore fine tuning the icons (iterate).
I don't want to go further in case you don't like it or want me to move in another direction. Here is the state I am now:
actual
proposed
window screenshot
video
https://github.com/user-attachments/assets/929abc5e-37fd-4b5a-a60c-14a77dbb9e97
set of new icons (in case you want to play with them)
preview_icons.zip
In the way I fixed some little errors in the QSS and "deactivated" the actual keyframe spinbox hover state as you can't really use it to type anything...
Let me know what do you think about the subject
Cheers