-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Go Docker API #21
Merged
Merged
Go Docker API #21
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
2a5b3c0
[cw|#6] quickly document on `xaqt` library on a high level
aad7683
[cw|#6] refactor sandbox to use go docker api
d29f7f9
[cw|#6] fix wait race condition: WaitConditionStopped -> WaitConditio…
7f3b56b
[cw|#6] vendor deps using `govendor` & update README
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,16 @@ | ||
# XAQT Library | ||
*TODO (cw|4.28.2018) create godocs instead of this file...these are mostly notes for myself during development.* | ||
|
||
# Public Types | ||
* **`xaqt.Context`**: entrypoint into all functionality. TODO Propose renaming? | ||
* **`xaqt.Compilers`**: list of compilters. Propose re-typing to `[]Compiler`. | ||
* **`xaqt.Message`**: details on success or failure of execution | ||
|
||
# Public Methods | ||
|
||
``` go | ||
func NewContext(xaqt.Compilers, ...option) // option should be public! | ||
func (ctx *Context) ReadCompilers(string) | ||
func (ctw *Context) Languages([]string) // rename -> GetSupportedLanguages ? | ||
func (ctw *Context) Evaluate(string, string, []string) | ||
``` |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah despite naming it that, I don't love it... especially now that we're using the
Context
library.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah, i feel you, naming is hard and often doesn't feel like it holds up over time as the code progresses-- luckily this is a painless refactor at this point, so if we decide on a good rename we can change it. i won't do it in this PR since its not super relevant...but we can think it over :)