Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

patches: add support for Zyxel NWA1121 #39

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

CodeFetch
Copy link

Oliver gave me some of these devices.
This patch adds support for them.

@Dark4MD I'd really like to have an image for them. I haven't tested it. Let's see what Jenkins says...

Oliver gave me some of these devices.
This patch adds support for them.
@Dark4MD
Copy link
Member

Dark4MD commented Jun 22, 2019

i tried building it on my local build machine. first try i got an error (without verbose so i did not see the error), second try the build process waited for me to answear if he should build an image for this device and i answered with y and it continued:
Zyxel NWA1121 support (ATH79_MACH_NWA1121) [N/y] (NEW) y
Here is the resulting image for you to try:
https://drive.google.com/open?id=1JdtXiXoAROM4NR-61PNg48y7yNxNyTqC

@CodeFetch
Copy link
Author

@Dark4MD Thank you very much. Unfortunately I don't have access to your Google drive. Please use e.g. https://transfer.sh instead.

@Dark4MD
Copy link
Member

Dark4MD commented Jun 24, 2019

https://transfer.sh/m9UUy/gluon-ffh-vH0.dev.20190622-zyxel-nwa1121-sysupgrade.bin
Sry was my first time public sharing a file after switch from onedrive to google drive.

@CodeFetch
Copy link
Author

Thank you very much. Unfortunately the patch writer did not know about partitioning in OpenWrt. Thus I need to change the layout later.

@AiyionPrime
Copy link
Member

AiyionPrime commented Apr 5, 2020

Codefetch may unblock this, if he changed the layout.

@Dark4MD
Copy link
Member

Dark4MD commented Jul 13, 2021

Someone is working on support for this device an even for the ATH79 Target :D
openwrt/openwrt#4037

Oh, just saw that he is one of us XD Explains a lot

@AiyionPrime
Copy link
Member

Looks like @s-2 's upstream contribution right now just needs an updated commit message?
That would imply e.g. @CodeFetch could test it?

@AiyionPrime
Copy link
Member

@CodeFetch was the request to merge this into master intentional? Shouldn't we start with nightly?

@CodeFetch CodeFetch marked this pull request as draft August 12, 2021 10:41
@CodeFetch
Copy link
Author

CodeFetch commented Aug 12, 2021

@AiyionPrime No, this is just kept open for reference.
We only have 10 or so NWA1121-NI (single band, consumer), but 70 NWA5123-NI (dual band, enterprise with bootloader locked). For the latter a special firmware format is needed openwrt/openwrt#4420 and s-2 is working on a device support PR. NWA1121-NI is not so important atm.

@s-2
Copy link
Contributor

s-2 commented Aug 12, 2021

Looks like @s-2 's upstream contribution right now just needs an updated commit message?

Is there anything that should be improved regarding the commit messages of #4037?

I had tested NWA-1121-NI with gluon months ago, meanwhile the device vanished from the map since I had to flash it back to OpenWrt for testing changes made to the PR.

@Neustradamus
Copy link

I hope a merging in OpenWrt...

@AiyionPrime
Copy link
Member

AiyionPrime commented Sep 6, 2022

@s-2 @CodeFetch openwrt/openwrt@251ecfe was merged 16 days ago.

Time to rebase this accordingly and reduce it to a gluon-only patch.

@AiyionPrime
Copy link
Member

@CodeFetch I suppose a 'backport' into this PR would be pretty easy given that 22.03 isn't that far from master yet.

But @s-2 and me came to the conclusion that we won't do that for this device.

Do you intend to?
If so let me know, else I'd close this.

@s-2
Copy link
Contributor

s-2 commented Oct 18, 2022

Current state of gluon patch is here: https://github.com/s-2/gluon/tree/zyxel_nwa11xx
This would only apply to gluon after switching to the OpenWrt 23.xx release branch one day (or backporting the devices via site).

@Neustradamus
Copy link

@s-2: I hope!

@AiyionPrime
Copy link
Member

This needs a rebase, if this should ever happen.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants