Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: open-vm-tools package for x86 #367

Closed
wants to merge 1 commit into from
Closed

Conversation

GoliathLabs
Copy link
Member

I've run black as well, not sure if I should revert it.

@GoliathLabs GoliathLabs requested review from maurerle and a team as code owners March 3, 2024 22:15
@GoliathLabs GoliathLabs closed this Mar 4, 2024
Copy link
Contributor

@grische grische left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@GoliathLabs black formatting would introduce too many changes in comparison to the upstream variants and comparison much harder.

@maurerle
Copy link
Collaborator

maurerle commented Mar 10, 2024

One might as well add qemu-ga (only to x86-64) for qemu-guest-agent - though grische said, that he had some build failures with ffmuc firmware for this.
See https://github.com/ffac/site/blob/v2023.2.x/image-customization.lua#L186-L192

Furthermore, this is missing the respective change in the site.mk (or image-customization.lua in the next branch)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants