Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

contrib: add USB For TP-Link TL-WR1043N v5 #343

Merged
merged 1 commit into from
Dec 30, 2023
Merged

contrib: add USB For TP-Link TL-WR1043N v5 #343

merged 1 commit into from
Dec 30, 2023

Conversation

grische
Copy link
Contributor

@grische grische commented Dec 22, 2023

No description provided.

@grische grische requested review from maurerle and a team as code owners December 22, 2023 13:01
@grische grische added stable backport next Backport to Next Branch labels Dec 30, 2023
@grische grische merged commit 2f1291d into freifunkMUC:stable Dec 30, 2023
28 checks passed
@grische grische deleted the feature/contrib-usb-tp-link-tl-wr1043n-v5 branch December 30, 2023 13:28
@github-actions GitHub Actions
Copy link
Contributor

Successfully created backport PR for next:

@github-actions github-actions bot mentioned this pull request Dec 30, 2023
Merged
@herbetom
Copy link
Contributor

herbetom commented Jan 1, 2024 •
edited
Loading

Is there a reason for this change? The v5 doesn't have a USB Port.

In fact there was #238 earlier this year to remove USB Packages from the v5.

@grische
Copy link
Contributor Author

grische commented Jan 1, 2024

Is there a reason for this change? The v5 doesn't have a USB Port.

In fact there was #238 earlier this year to remove USB Packages from the v5.

Oh, I thought it had one . This was a cherry-pick from the ffac repo. @maurerle do you know why USB was added there?

@herbetom
Copy link
Contributor

herbetom commented Jan 1, 2024

In the end it doesn't really matter with `image-customization.lua" on the horizon. I was just curious. My guess would be then that ffac just never applied the removal patch.

@grische grische mentioned this pull request Jan 3, 2024
Merged
@grische
Copy link
Contributor Author

grische commented Jan 3, 2024

Let's revert this then, no benefit of having this: #351

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GoliathLabs GoliathLabs GoliathLabs approved these changes

@maurerle maurerle Awaiting requested review from maurerle maurerle is a code owner

Assignees
No one assigned
Labels
backport next Backport to Next Branch stable
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@grische @herbetom @GoliathLabs