Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

site: install ffac-eol-ssid on all devices #291

Merged

Conversation

grische
Copy link
Contributor

@grische grische commented Nov 6, 2023

As this branch only builds for legacy devices, it is safe to assume that all devices installing firmware here need updating.

As this branch only builds for legacy devices, it is safe to assume that
all devices installing firmware here need updating.
@grische grische requested a review from a team as a code owner November 6, 2023 22:54
@grische grische added the legacy Applies on legacy branch label Nov 6, 2023
Copy link
Collaborator

@maurerle maurerle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Coll that no device complaint about filesizes! :)

@grische
Copy link
Contributor Author

grische commented Nov 7, 2023

@maurerle the ffac-eol-ssid was already installed in most EOL devices, see

for target in ['ar71xx-tiny', 'ramips-rt305x']:
targets.get(target). \
add_pkglist(PKGS_EOL)

This PR makes sure that ALL devices have the EOL-SSID, as no one should install the legacy-branch firmware on a device that has proper stable firmware.

To enable auto-updates for legacy+stable devices, we will be using this:
https://github.com/freifunkMUC/ffmuc-salt-public/blob/11525ec4e8fb15f993a067cfc03e7752d1231479/github-downloader/firmware-legacy-merger#L9-L14

@maurerle
Copy link
Collaborator

maurerle commented Nov 7, 2023

Yes, looks good. I did not look to deep into the github-downloader though.

Not the topic here, but in FFAC we have different paths for different release branches:
So updates for v2023.1.x based firmwares are fetched from http://updates.freifunk-aachen.de/from-2023.1.x/stable/sysupgrade - which contains the latest recommended images

Old branches can get updates from http://updates.freifunk-aachen.de/from-2021.1.x/stable/sysupgrade
Or I can symlink the from-2023.1.x firmware to the upgrade folder of from-2021.1.x to let all possible devices update to the latest release if possible.

But merging things into one download dir probably works too :)

@maurerle maurerle merged commit 814d48e into freifunkMUC:legacy Nov 7, 2023
26 checks passed
@grische grische deleted the feature/enable_eolssid_on_all_devices branch November 7, 2023 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
legacy Applies on legacy branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants