Strtod reimplementation #69
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This does not need the gmp functions anymore, and compiles to much smaller code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not yet complete, but looks rather promising (seems to be have similar origin as the implementation in libcmini).
Already adjusted for mintlibs purpose (provides the _internal* functions needed by scanf()). Does hot handle group separators or locales yet (but that is also the case in current implementation).
Whats missing:
Both should not be hard to implement.
What would regress: the algorithm does not parse strings that would result in denormals. There may also be differences in the least significant bit due to rounding.
The functions currently generate ~1K of code, including the tables, with only minimal references to libgcc.a for some float functions in the 68k version.