adapt file generation for compose fragments #542
Merged
+119
−117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gabrielittner
approved these changes
Sep 22, 2023
| @@ -185,7 +185,7 @@ internal class FileGeneratorTestComposeFragment { | |||
|
|
|||
| """.trimIndent() | |||
|
|
|||
| test(data, "com/test/Test.kt", source, expected) | |||
| test(data, "com/test/FragmentTest.kt", source, expected) | |||
There was a problem hiding this comment.
This one should stay as Test.kt as it's the file name for the sources, not for the generated code. Same for the other tests below.
There was a problem hiding this comment.
I gotta say I'm confused, from what I see it uses the file name to find and read the generated file and compares its content to the expected string. When I didn't update it all the tests would fail as the files were not found. What did I get wrong here?
There was a problem hiding this comment.
Ah, we're computing the generated file name based on this as well https://github.com/freeletics/khonshu/blob/main/codegen-compiler/src/testFixtures/kotlin/com/freeletics/khonshu/codegen/KhonshuCompilation.kt#L154-L158. So let's keep it as is
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've changed the file generation for compose fragments to include "Fragment" in the name. This. will allow for generating both the compose only and fragment setup if needed.