Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(set_mp3_meta_data): update publisher logo to new FLP logo #195

Merged
merged 1 commit into from
Jul 5, 2024

Conversation

grossir
Copy link
Contributor

@grossir grossir commented Jul 5, 2024

I am using this logo converted from png to svg using rsvg-convert from package librsvg2-bin on Ubuntu

How the audio file looks on Ubuntu file explorer, when there is both s, "Front Cover" and "Publisher logo" metadata
image

How it looks when there is only "Publisher logo" metadata
image


ffprobe output recognizes both images, "Front Cover" and "Publisher logo". See Stream #0:1 and Stream #0:2

As an aside, I tested using the svg image directly, with a mime type "image/svg", and my file explorer would recognize and render the image; however, ffprobe would tag it as invalid Unknown attached picture mimetype: image/svg, skipping., which does not happen when using a png

$ ffprobe project_veritas_v._michael_schmidt_cl.mp3 

ffprobe version 4.2.7-0ubuntu0.1 Copyright (c) 2007-2022 the FFmpeg developers
  built with gcc 9 (Ubuntu 9.4.0-1ubuntu1~20.04.1)
  configuration: --prefix=/usr --extra-version=0ubuntu0.1 --toolchain=hardened --libdir=/usr/lib/x86_64-linux-gnu --incdir=/usr/include/x86_64-linux-gnu --arch=amd64 --enable-gpl --disable-stripping --enable-avresample --disable-filter=resample --enable-avisynth --enable-gnutls --enable-ladspa --enable-libaom --enable-libass --enable-libbluray --enable-libbs2b --enable-libcaca --enable-libcdio --enable-libcodec2 --enable-libflite --enable-libfontconfig --enable-libfreetype --enable-libfribidi --enable-libgme --enable-libgsm --enable-libjack --enable-libmp3lame --enable-libmysofa --enable-libopenjpeg --enable-libopenmpt --enable-libopus --enable-libpulse --enable-librsvg --enable-librubberband --enable-libshine --enable-libsnappy --enable-libsoxr --enable-libspeex --enable-libssh --enable-libtheora --enable-libtwolame --enable-libvidstab --enable-libvorbis --enable-libvpx --enable-libwavpack --enable-libwebp --enable-libx265 --enable-libxml2 --enable-libxvid --enable-libzmq --enable-libzvbi --enable-lv2 --enable-omx --enable-openal --enable-opencl --enable-opengl --enable-sdl2 --enable-libdc1394 --enable-libdrm --enable-libiec61883 --enable-nvenc --enable-chromaprint --enable-frei0r --enable-libx264 --enable-shared
  libavutil      56. 31.100 / 56. 31.100
  libavcodec     58. 54.100 / 58. 54.100
  libavformat    58. 29.100 / 58. 29.100
  libavdevice    58.  8.100 / 58.  8.100
  libavfilter     7. 57.100 /  7. 57.100
  libavresample   4.  0.  0 /  4.  0.  0
  libswscale      5.  5.100 /  5.  5.100
  libswresample   3.  5.100 /  3.  5.100
  libpostproc    55.  5.100 / 55.  5.100
Input #0, mp3, from 'project_veritas_v._michael_schmidt_cl.mp3':
  Metadata:
    comment         : Argued: 2024-06-25. Docket number: 22-35271
    album           : Court of Appeals for the Ninth Circuit, 2024
    genre           : Speech
    date            : 2024-06-25
    title           : Project Veritas v. Michael Schmidt
    artist          : Court of Appeals for the Ninth Circuit
    publisher       : Free Law Project
  Duration: 01:03:41.51, start: 0.050111, bitrate: 48 kb/s
    Stream #0:0: Audio: mp3, 22050 Hz, stereo, fltp, 48 kb/s
    Stream #0:1: Video: png, rgba(pc), 210x210, 90k tbr, 90k tbn, 90k tbc (attached pic)
    Metadata:
      title           : Created for the public domain by Free Law Project
      comment         : During recording
    Stream #0:2: Video: png, rgba(pc), 256x255 [SAR 2835:2835 DAR 256:255], 90k tbr, 90k tbn, 90k tbc (attached pic)
    Metadata:
      title           : Seal for Court of Appeals for the Ninth Circuit
      comment         : Cover (front)

Copy link

sentry-io bot commented Jul 5, 2024

🔍 Existing Issues For Review

Your pull request is modifying functions with the following pre-existing issues:

📄 File: doctor/tasks.py

Function Unhandled Issue
set_mp3_meta_data OSError: file not found: /tmp/audio_ed1208396689465a9185e47376e5cfcf /...
Event Count: 1

Did you find this useful? React with a 👍 or 👎

@mlissner
Copy link
Member

mlissner commented Jul 5, 2024

This looks great to me. Any reason it's still a draft?

@ERosendo
Copy link
Contributor

ERosendo commented Jul 5, 2024

@mlissner I noticed a discrepancy in the dimensions of the new logo compared to the old one. For consistency, let's make sure the new logo uses the same dimensions as the previous one. Additionally, the old logo had a white background, while the new one appears transparent.

Here's a file with the same dimensions (300x300) and a white background.

producer-300x300

@mlissner
Copy link
Member

mlissner commented Jul 5, 2024

Great points, thanks!

@grossir grossir marked this pull request as ready for review July 5, 2024 22:14
@grossir grossir merged commit 9e0e76f into freelawproject:main Jul 5, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants