Add Journal to Citation model type #4776
Conversation
Add citation type journal which can be either a scholarly publication or trade publication
🔍 Existing Issues For ReviewYour pull request is modifying functions with the following pre-existing issues: 📄 File: cl/citations/utils.py
📄 File: cl/corpus_importer/management/commands/update_casenames_wl_dataset.py (Click to Expand)
Did you find this useful? React with a 👍 or 👎 |
| if len(found_cites) == 0: | ||
| logger.info("Unable to parse %s", cite_str) | ||
| continue |
There was a problem hiding this comment.
Isn't this the same as line 141?
There was a problem hiding this comment.
yes sorry let me clean this up .
There was a problem hiding this comment.
No, I take that back. That’s not what I meant to write. The issue here is that we are correctly finding one citation when we pass in a single string citation, which is expected. However, the problem arises because the function identifies two editions for this citation: one journal and one reporter. We don’t want to arbitrarily choose the first one
Fix tests and implement stricker edition checking
fix refactor variable name
|
@mlissner looks like we are good to go - but there is a noop migration so I wouldn't merge this without your approval. |
Add Journal as type of citation in the model
We added journals to eyecite, but it turns out many of the parallel citations are are in fact
journals. This distinction can be found in eyecite so it is worth bringing that distinction over
to CL.
This change is needed to resolve #4775.
The alternative was to map journals to specialty reporters - but that did not seem correct.