feat(assets): Adds EOY banner #4771
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit introduces a new parameter to the dismissible banner template, enabling more customizable layouts.
|
@mlissner Really? I thought you wanted a red background. |
|
I've disabled auto-merge since this banner will replace the current one. I plan to merge this PR later today. |
|
Oops on both counts! Yes to red and yes to merging when the time is right! |
|
Got it! I'll update the template |
|
Ok, the banner is red now. See screenshots below: Small screens
Medium screens
Large screens
|
|
Looks great to me! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #4769 by updating the content of the banner to show our end-of-year message.
It also tweaks the dismissible template to use a two-row layout, which should make it easier to read.
Small screens
Medium screens
Large screens