Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(opinions.html): Ensure Case Name displays #4765

Merged
merged 3 commits into from
Dec 3, 2024

Conversation

flooie
Copy link
Contributor

@flooie flooie commented Dec 2, 2024

Fixes Missing Case Names when Case Name Full is the only name

We missed this before - and should ensure we display a case name
or a case name full in the caption if its the only thing available.

If case name full is the only case name
use it and then dont display it in the
metadata section
@flooie flooie requested a review from mlissner December 2, 2024 20:34
Copy link
Member

@mlissner mlissner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you can accomplish this by using the best_case_name template filter, no?

@flooie
Copy link
Contributor Author

flooie commented Dec 3, 2024

Thats a great idea thank you @mlissner

@flooie flooie requested a review from mlissner December 3, 2024 14:40
@flooie flooie assigned mlissner and unassigned flooie Dec 3, 2024
@mlissner mlissner merged commit 2dc20f4 into main Dec 3, 2024
15 checks passed
@mlissner mlissner deleted the fix-front-end-case-name branch December 3, 2024 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants