Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: Publish the built artifacts. #972

Merged
merged 1 commit into from
Dec 2, 2024
Merged

build: Publish the built artifacts. #972

merged 1 commit into from
Dec 2, 2024

Conversation

almet
Copy link
Contributor

@almet almet commented Oct 28, 2024

  • Fedora .rpm files
  • Windows .msi
  • macOS .app

Are now published as part of the CI pipelines.

Copy link
Contributor

@apyrgio apyrgio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! I had only a few nits, but other than that, it looks good to merge.

.github/workflows/ci.yml Outdated Show resolved Hide resolved
@almet almet requested a review from apyrgio November 26, 2024 16:00
@almet
Copy link
Contributor Author

almet commented Nov 26, 2024

I've rebased this branch on top of the latest main and addressed your comments. Let me know what you think @apyrgio!

@almet almet force-pushed the upload-artifacts branch 2 times, most recently from 1f16c25 to 0f11d7c Compare November 26, 2024 16:42
@almet almet added this to the 0.9.0 milestone Nov 27, 2024
@apyrgio
Copy link
Contributor

apyrgio commented Nov 29, 2024

Looks good, thanks!

- Fedora `.rpm` files
- Windows `.msi`
- macOS `.app`

Are now published as part of the CI pipelines.
@almet almet merged commit 23f5f96 into main Dec 2, 2024
45 checks passed
@almet almet deleted the upload-artifacts branch December 2, 2024 10:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants