Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: add poetry-plugin-export to the dependencies #1043

Merged
merged 2 commits into from
Jan 8, 2025
Merged

Conversation

almet
Copy link
Contributor

@almet almet commented Jan 6, 2025

Since Poetry 2.0.0, the export command has been removed and it's advised to use the "poetry-plugin-export" package instead.

This commit adds this dependency to the different places it's needed (debian environments, CI, build instructions etc).

I also took the chance to include env.py in the hashed files for the dev containers.

Fixes #825

@apyrgio
Copy link
Contributor

apyrgio commented Jan 7, 2025

Looks good to me, feel free to merge. Minor note, there's a typo in the first commit of the PR (s/it's needsd/it's needed/).

almet added 2 commits January 8, 2025 06:18
Since Poetry 2.0.0, the `export` command has been removed and it's
advised to use the "poetry-plugin-export" package instead.

This commit adds this dependency to the different places it's needed
(debian environments, CI, build instructions, etc).
It contains information that define the build environments, and as such, modifying it should result in a new release of the dev containers.
@almet almet force-pushed the test/poetry-export branch from 3e6c9da to 1298e9c Compare January 8, 2025 05:18
@almet almet merged commit 1298e9c into main Jan 8, 2025
37 checks passed
@almet almet deleted the test/poetry-export branch January 8, 2025 05:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Install poetry-plugin-export, as it will not be installed by default in future poetry versions
2 participants