-
-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: move storybook config files to use typescript #374
base: main
Are you sure you want to change the base?
chore: move storybook config files to use typescript #374
Conversation
5ed3484
to
594ced6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the PR.
I'm afraid renaming the files is not enough. I pulled the branch down and got some TS errors in main.ts
, manager.ts
, and theme.ts
.
Those TS errors should be reported when the typecheck
command runs, but they currently aren't. So there should be some changes to the tsconfig file as well.
c6b794f
to
cba6c5a
Compare
I added some missing packages Which seem to resolve ts errors (hope u will have time to review) |
cba6c5a
to
f63d2c0
Compare
updated the PR.. hope this time is good |
f63d2c0
to
50e4c34
Compare
New and removed dependencies detected. Learn more about Socket for GitHub ↗︎
🚮 Removed packages: npm/[email protected] |
is something wrong with this PR , which need update? |
50e4c34
to
9313116
Compare
9313116
to
471aa4f
Compare
Checklist:
Update index.md
)Closes #369