Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: move storybook config files to use typescript #374

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

shootermv
Copy link
Contributor

Checklist:

Closes #369

@shootermv shootermv requested a review from a team as a code owner October 13, 2024 08:45
@shootermv shootermv force-pushed the convert-storybook-config-files-to-ts branch from 5ed3484 to 594ced6 Compare October 20, 2024 14:07
Copy link
Member

@huyenltnguyen huyenltnguyen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR.

I'm afraid renaming the files is not enough. I pulled the branch down and got some TS errors in main.ts, manager.ts, and theme.ts.

Those TS errors should be reported when the typecheck command runs, but they currently aren't. So there should be some changes to the tsconfig file as well.

@huyenltnguyen huyenltnguyen added the status: waiting update To be applied to PR if a maintainer/reviewer has left a feedback and follow up is needed from OP label Oct 24, 2024
@shootermv shootermv force-pushed the convert-storybook-config-files-to-ts branch 2 times, most recently from c6b794f to cba6c5a Compare October 24, 2024 18:00
@shootermv
Copy link
Contributor Author

I added some missing packages Which seem to resolve ts errors (hope u will have time to review)

@shootermv shootermv force-pushed the convert-storybook-config-files-to-ts branch from cba6c5a to f63d2c0 Compare November 8, 2024 11:35
@shootermv
Copy link
Contributor Author

updated the PR.. hope this time is good

@shootermv shootermv force-pushed the convert-storybook-config-files-to-ts branch from f63d2c0 to 50e4c34 Compare November 8, 2024 12:24
Copy link

socket-security bot commented Nov 8, 2024

@shootermv
Copy link
Contributor Author

is something wrong with this PR , which need update?

@ilenia-magoni ilenia-magoni added the status: merge conflict To be applied to PR's that have a merge conflict and need updating label Nov 18, 2024
@shootermv shootermv force-pushed the convert-storybook-config-files-to-ts branch from 50e4c34 to 9313116 Compare November 18, 2024 11:10
@shootermv shootermv force-pushed the convert-storybook-config-files-to-ts branch from 9313116 to 471aa4f Compare November 25, 2024 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: merge conflict To be applied to PR's that have a merge conflict and need updating status: waiting update To be applied to PR if a maintainer/reviewer has left a feedback and follow up is needed from OP
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Convert Storybook config files to TypeScript
3 participants