Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: create tests for tags #360

Merged
merged 12 commits into from
Nov 30, 2023
Merged

feat: create tests for tags #360

merged 12 commits into from
Nov 30, 2023

Conversation

Sembauke
Copy link
Member

@Sembauke Sembauke commented Nov 29, 2023 •
edited
Loading

ref #356

@Sembauke Sembauke marked this pull request as ready for review November 29, 2023 10:52
@Sembauke Sembauke requested a review from a team as a code owner November 29, 2023 10:52
ojeytonwilliams
ojeytonwilliams reviewed Nov 29, 2023
View reviewed changes
e2e/tag.spec.ts Outdated Show resolved Hide resolved
@ojeytonwilliams
Copy link
Contributor

@Sembauke I think this is fine, now. All the tests can be run repeatedly and in any order and should not cause any issues.

Once we have a lot of tests, it might be worth using api calls to setup/teardown any state we need for the tests. Just to speed things up. However, for now, I think this approach is fine.

@Sembauke Sembauke requested a review from sidemt November 29, 2023 17:22
sidemt
sidemt approved these changes Nov 30, 2023
View reviewed changes
Copy link
Member

@sidemt sidemt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm having difficulties running playwright tests locally, but as far as I read through the code LGTM.

@sidemt sidemt merged commit 463244c into main Nov 30, 2023
7 checks passed
@sidemt sidemt deleted the feat/tests-for-tag-page branch November 30, 2023 16:13
@ojeytonwilliams
Copy link
Contributor

I'm having difficulties running playwright tests locally

What's going wrong, @sidemt? It sounds like I need to update the docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sidemt sidemt sidemt approved these changes

@ojeytonwilliams ojeytonwilliams Awaiting requested review from ojeytonwilliams

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Sembauke @ojeytonwilliams @sidemt