feat: new ast-based helpers + fix has_args, has_decorators #203
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dario-DC
commented
May 6, 2024
python/py_helpers.py
Outdated
| @@ -424,6 +436,20 @@ def _find_conditions(tree): | |||
|
|
|||
| return [Node(test) for test in _find_conditions(self.tree)] | |||
|
|
|||
| # Returs a Boolean indicating if node1 comes before node2 | |||
| def is_ordered(self, node1, node2): | |||
There was a problem hiding this comment.
Please, help me find a better name for this.
There was a problem hiding this comment.
The name is fine as it is serving the intended purpose 👍️
|
Currently the TypeError: Node.is_ordered() takes 3 positional arguments but 5 were given |
|
The method is also working perfect for non-consecutive statements. This could be mentioned in docs. |
|
The updated changes are working now for a variable number of arguments in |
zairahira
approved these changes
May 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist:
Update index.md)Closes #XXXXX