Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: delete UPF.UPIPInfo field #138

Merged
merged 1 commit into from
Dec 25, 2024
Merged

fix: delete UPF.UPIPInfo field #138

merged 1 commit into from
Dec 25, 2024

Conversation

yoursunny
Copy link
Contributor

fixes #137

@yoursunny
Copy link
Contributor Author

I took the approach of deleting UPF.UPIPInfo field, rather than adding a nil-pointer check, because:

  • The UserPlaneIPResourceInformation field has been deleted since 3GPP R16.
  • The only place UPF.UPIPInfo is referenced in the code is in SelectUPFByDnn function.
  • SelectUPFByDnn function is not called anywhere.

@ianchen0119 ianchen0119 merged commit 8fa79e3 into free5gc:main Dec 25, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ianchen0119 ianchen0119 ianchen0119 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

pfcp/handler.HandlePfcpAssociationSetupRequest: nil pointer dereference
2 participants
@yoursunny @ianchen0119