fix: Missing URR creation will cause TI error

free5gc · Sep 30, 2024 · 736f3d1 · 736f3d1
1 parent 7d3d180
commit 736f3d1
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 3 deletions.
diff --git a/internal/context/datapath.go b/internal/context/datapath.go
@@ -831,7 +831,7 @@ func (p *DataPath) AddChargingRules(smContext *SMContext, chgLevel ChargingLevel
 						// nolint
 						nodeId, _ := node.GetUPFID()
 						logger.PduSessLog.Tracef("DownLinkTunnel add URR for node %s %+v",
-							nodeId, node.UpLinkTunnel.PDR)
+							nodeId, node.DownLinkTunnel.PDR)
 					}
 				}
 			}

diff --git a/internal/pfcp/message/build.go b/internal/pfcp/message/build.go
@@ -435,8 +435,9 @@ func BuildPfcpSessionEstablishmentRequest(
 		urrMap[urr.URRID] = urr
 	}
 	for _, filteredURR := range urrMap {
-		if filteredURR.State == context.RULE_INITIAL {
-			msg.CreateURR = append(msg.CreateURR, urrToCreateURR(filteredURR))
+		msg.CreateURR = append(msg.CreateURR, urrToCreateURR(filteredURR))
+		if filteredURR.State == context.RULE_CREATE {
+			smContext.Log.Warn("Duplicate URR creation")
 		}
 		filteredURR.State = context.RULE_CREATE
 	}
@@ -564,6 +565,9 @@ func BuildPfcpSessionModificationRequest(
 
 	for _, urr := range urrList {
 		switch urr.State {
+		case context.RULE_CREATE:
+			smContext.Log.Warn("Duplicate URR creation")
+			fallthrough
 		case context.RULE_INITIAL:
 			msg.CreateURR = append(msg.CreateURR, urrToCreateURR(urr))
 		case context.RULE_UPDATE: