Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exit or error early #71

Merged
merged 4 commits into from
Apr 4, 2024
Merged

Exit or error early #71

merged 4 commits into from
Apr 4, 2024

Conversation

deemp
Copy link
Contributor

@deemp deemp commented Apr 2, 2024

Fix #57 - attempt 2

@pbrisbin
Copy link
Member

pbrisbin commented Apr 2, 2024

Should we add a case to the CI suite that exposes the issue, so we can see that this PR doesn't re-introduce it?

I'm thinking we have an example Job with a test or compilation failure, then a dependent Job that asserts the Job that ran that has failed.

@deemp
Copy link
Contributor Author

deemp commented Apr 2, 2024

I think it's enough to have a step with a build failure.

  • Set continue-on-error for stack-action-step (link).

  • In the next step, check that the previous step failed (link).

    if: steps.stack-action-step.outcome != 'failure'
    run: exit 1

@deemp deemp force-pushed the main branch 2 times, most recently from 4d509a7 to 61d261e Compare April 2, 2024 20:11
@deemp
Copy link
Contributor Author

deemp commented Apr 2, 2024

Seems to work.

@pbrisbin
Copy link
Member

pbrisbin commented Apr 3, 2024

Thanks! I'll merge and release this this week.

@pbrisbin pbrisbin merged commit 5d245a7 into freckle:main Apr 4, 2024
18 of 19 checks passed
@pbrisbin
Copy link
Member

pbrisbin commented Apr 4, 2024

Released (again) in v5.1.3. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unexplainable delay after "Set outputs"
2 participants