-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support more granular stack arguments #35
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is looking pretty good, IMO. Just noted a few minor things.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great!
I'm going to pop a link in our team chat for others to take a peek before we commit to it as the new major version's inputs.
Co-authored-by: Pat Brisbin <[email protected]>
Co-authored-by: Pat Brisbin <[email protected]>
Apparently, no one is particularly interested in additional review on this. I plan to merge on Monday, release the new version, and start updating our usages. If you'd like to update the git history before then, please do and let me know. Otherwise, I will probably just Squash merge the whole thing. Thanks again! |
Thank you a lot for curating this PR! |
Consolidating this in #36 . |
stack <command>
invocationsstack-arguments
are now passed tostack
invocations (closes Specifying resolver instack-arguments
#26)