Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support more granular stack arguments #35

Closed
wants to merge 17 commits into from
Closed

Conversation

deemp
Copy link
Contributor

@deemp deemp commented Jan 19, 2024

  • Add new inputs to provide separate arguments for stack <command> invocations
  • stack-arguments are now passed to stack invocations (closes Specifying resolver in stack-arguments  #26)
  • Fix compiler checks in the example action
  • Run example action on all platforms
  • Convert multi-line inputs to single-line strings

Copy link
Member

@pbrisbin pbrisbin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is looking pretty good, IMO. Just noted a few minor things.

action.yml Outdated Show resolved Hide resolved
action.yml Outdated Show resolved Hide resolved
action.yml Outdated Show resolved Hide resolved
action.yml Outdated Show resolved Hide resolved
.github/workflows/example.yml Show resolved Hide resolved
.github/workflows/example.yml Outdated Show resolved Hide resolved
.github/workflows/example.yml Show resolved Hide resolved
Copy link
Member

@pbrisbin pbrisbin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great!

I'm going to pop a link in our team chat for others to take a peek before we commit to it as the new major version's inputs.

.github/workflows/example.yml Show resolved Hide resolved
.github/workflows/example.yml Outdated Show resolved Hide resolved
@pbrisbin
Copy link
Member

Apparently, no one is particularly interested in additional review on this. I plan to merge on Monday, release the new version, and start updating our usages. If you'd like to update the git history before then, please do and let me know. Otherwise, I will probably just Squash merge the whole thing.

Thanks again!

@deemp
Copy link
Contributor Author

deemp commented Jan 28, 2024

Thank you a lot for curating this PR!

@pbrisbin
Copy link
Member

Consolidating this in #36 .

@pbrisbin pbrisbin closed this Jan 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Specifying resolver in stack-arguments
2 participants