Add -type f to generate-matrix default find(1) options #166
+7
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This ensures we only list regular files and not symbolic links. It may be the case that a project symlinks `stack.yaml` to one of the specific configurations. In such cases, only the actual files should generate matrix elements. Generating one for `stack.yaml` would be redundant. Projects that attach extra tasks (weeder, coverage) to only the `stack.yaml` build should either not use a symlink, or adjust the `find` input accordingly.
chris-martin
approved these changes
Jan 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This ensures we only list regular files and not symbolic links. It may
be the case that a project symlinks
stack.yamlto one of the specificconfigurations. In such cases, only the actual files should generate
matrix elements. Generating one for
stack.yamlwould be redundant.Projects that attach extra tasks (weeder, coverage) to only the
stack.yamlbuild should either not use a symlink, or adjust thefindinput accordingly.