Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use stack-path instead of inferring --programs #115

Merged
merged 4 commits into from
Aug 27, 2024
Merged

Use stack-path instead of inferring --programs #115

merged 4 commits into from
Aug 27, 2024

Conversation

pbrisbin
Copy link
Member

@pbrisbin pbrisbin commented Aug 27, 2024 •
edited
Loading

Closes #60.

@pbrisbin pbrisbin changed the title pb/path programs Use stack-path instead of inferring --programs Aug 27, 2024
@pbrisbin
Copy link
Member Author

Seems to work:

@pbrisbin
Copy link
Member Author

/cc @deemp

@pbrisbin pbrisbin requested a review from chris-martin August 27, 2024 14:45
@pbrisbin pbrisbin marked this pull request as ready for review August 27, 2024 14:45
@pbrisbin pbrisbin requested a review from stackptr August 27, 2024 14:45
@pbrisbin pbrisbin enabled auto-merge (rebase) August 27, 2024 14:57
@pbrisbin pbrisbin merged commit eb40503 into main Aug 27, 2024
20 checks passed
@pbrisbin pbrisbin deleted the pb/path-programs branch August 27, 2024 18:40
@deemp
Copy link
Contributor

deemp commented Aug 27, 2024

@pbrisbin, nice that you've implemented this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stackptr stackptr stackptr approved these changes

@chris-martin chris-martin Awaiting requested review from chris-martin

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Consider using stack path instead of custom logic
3 participants
@pbrisbin @deemp @stackptr