Restyle Add freckle/haskell-library-template
.
#4
Annotations
1 error and 11 warnings
Run haskell/actions/hlint-run@v2
HLint failed with status: 1. Warning (7), Suggestion (5)
|
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: haskell/actions/hlint-setup@v2, haskell/actions/hlint-run@v2. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
|
Run haskell/actions/hlint-run@v2:
library/Database/Memcache/Cluster.hs#L161
Suggestion in newCluster in module Database.Memcache.Cluster: Redundant bracket ▫︎ Found: "Cluster\n {cServers = (V.fromList $ sort s), cRetries = optsServerRetries,\n cFailDelay = fromEnum optsFailRetryDelay,\n cDeadDelay = fromRational $ toRational optsDeadRetryDelay / 1000,\n cTimeout = fromEnum optsServerTimeout,\n cGetServerForKey = optsGetServerForKey}" ▫︎ Perhaps: "Cluster\n {cServers = V.fromList $ sort s, cRetries = optsServerRetries,\n cFailDelay = fromEnum optsFailRetryDelay,\n cDeadDelay = fromRational $ toRational optsDeadRetryDelay / 1000,\n cTimeout = fromEnum optsServerTimeout,\n cGetServerForKey = optsGetServerForKey}"
|
Run haskell/actions/hlint-run@v2:
library/Database/Memcache/Sid.hs#L38
Warning in splitIntoNRanges in module Database.Memcache.Sid: Use min ▫︎ Found: "if succ (leftSubRangeMax r) >= globalMax then\n globalMax\nelse\n succ (leftSubRangeMax r)" ▫︎ Perhaps: "min (succ (leftSubRangeMax r)) globalMax"
|
Run haskell/actions/hlint-run@v2:
library/Database/Memcache/Sid.hs#L43
Warning in splitIntoNRanges in module Database.Memcache.Sid: Use min ▫︎ Found: "if leftRangeMax' >= globalMax then globalMax else leftRangeMax'" ▫︎ Perhaps: "min leftRangeMax' globalMax"
|
Run haskell/actions/hlint-run@v2:
library/Database/Memcache/Types.hs#L87
Suggestion in mEMCACHE_HEADER_SIZE in module Database.Memcache.Types: Use camelCase ▫︎ Found: "mEMCACHE_HEADER_SIZE :: Int" ▫︎ Perhaps: "mEMCACHEHEADERSIZE :: Int"
|
Run haskell/actions/hlint-run@v2:
library/Database/Memcache/Types.hs#L88
Suggestion in mEMCACHE_HEADER_SIZE in module Database.Memcache.Types: Use camelCase ▫︎ Found: "mEMCACHE_HEADER_SIZE = ..." ▫︎ Perhaps: "mEMCACHEHEADERSIZE = ..."
|
Run haskell/actions/hlint-run@v2:
library/Database/Memcache/Types.hs#L145
Suggestion in SETouch in module Database.Memcache.Types: Use newtype instead of data ▫︎ Found: "data SETouch\n = SETouch Expiration\n deriving stock (Eq, Show)" ▫︎ Perhaps: "newtype SETouch\n = SETouch Expiration\n deriving stock (Eq, Show)" ▫︎ Note: decreases laziness
|
Run haskell/actions/hlint-run@v2:
scraps/LClient.hs#L35
Warning in getClient in module Database.Memcache.LClient: Use unless ▫︎ Found: "when (not b)" ▫︎ Perhaps: "unless b"
|
Run haskell/actions/hlint-run@v2:
tests/full/MockServer.hs#L60
Warning in mockMCServer in module MockServer: Redundant bracket ▫︎ Found: "(N.close)" ▫︎ Perhaps: "N.close"
|
Run haskell/actions/hlint-run@v2:
tests/full/MockServer.hs#L83
Warning in mockMCServer in module MockServer: Use when ▫︎ Found: "if cont then acceptHandler sock ref else return ()" ▫︎ Perhaps: "when cont $ acceptHandler sock ref"
|
Run haskell/actions/hlint-run@v2:
tools/Loader.hs#L75
Warning in parseArguments in module Main: Use unless ▫︎ Found: "when (not $ null errs)" ▫︎ Perhaps: "unless (null errs)"
|
Loading