Ensure status descriptions are not over 140 characters #239
+44
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It may not be clear that the `HALT` file contents are meant to be
formatted like a commit or PR, with a reasonable-length title and
optional body below.
When folks write things as one long line, that is interpreted as title
and used as the status description, and we get:
Setting halted status for PR #37776
Error: HttpError: Validation Failed: {"resource":"Status","code":"custom","field":"description","message":"description is too long (maximum is 140 characters)"}
We can just truncate to avoid it.
pbrisbin
changed the title
pbrisbin
requested review from
derelbenkoenig
and removed request for
a team
StevenXL
approved these changes
Dec 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It may not be clear that the
HALTfile contents are meant to beformatted like a commit or PR, with a reasonable-length title and
optional body below.
When folks write things as one long line, that is interpreted as title
and used as the status description, and we get:
We can just truncate to avoid it.